Repository navigation
LTX-2 quantization example: filter calibration extra-params, document supported LTX commit - #2869
Open
Edwardf0t1 wants to merge 1 commit into
Open
Edwardf0t1 wants to merge 1 commit into
Edwardf0t1 wants to merge 1 commit into
Conversation
…nt supported LTX commit Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2869 +/- ##
=======================================
Coverage 76.99% 76.99%
=======================================
Files 658 658
Lines 73950 73950
=======================================
Hits 56939 56939
Misses 17011 17011
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cjluo-nv
reviewed
Oct 20, 2026
cjluo-nv
left a comment
Collaborator
There was a problem hiding this comment.
Bot review (bedrock-claude-opus-5-5) — DM the bot to share feedback.
Nudging: the filter is correct, but neither it nor the documented LTX-2 pin has been run, so an owner with an LTX setup should confirm both.
Needs action:
- Confirm
quantize.py --model ltx-2 ... --extra-param height=512gets pastTI2VidTwoStagesPipeline(...)construction on LTX-2 commit28c3c73. - Confirm the README's
pip install ...@28c3c73line installs alongside ModelOpt'stransformers>=5.5. If it doesn't, say so in the note so users don't hit a dependency conflict. - Consider adding a small unit test that mocks
ltx_core/ltx_pipelinesinsys.modules. It would check that the calibration-only keys never reach the constructor kwargs.
No action needed:
- The 7 removed keys (
seed,height,width,num_frames,frame_rate,images,tiling_config) are exactly the ones_run_ltx2_calibrationreads fromextra_params. The keys are removed from a copy (dict(self.config.extra_params)), so calibration still sees them. - The README note is a version pin, not a licensing change. It sits next to the existing LTX license notice.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix (partial; the port to the new LTX API is a follow-up). NVBug 6932665.
_create_ltx2_pipelineno longer forwards calibration-only--extra-paramkeys (height,width,num_frames,frame_rate,seed,images,tiling_config) to theTI2VidTwoStagesPipelineconstructor, where they raisedTypeError.calibration.pystill reads them.28c3c73, which hasQuantizationPolicy.fp8_cast()andcheckpoint_path/gemma_root), with a pip install line, and says newer releases are unsupported.Not fixed here (follow-up): the example still fails on current LTX-2 releases (
QuantizationPolicy.fp8_castremoved;TI2VidTwoStagesPipelinenow takesmodel_paths: ModelPaths). Portingpipeline_manager.pyto the new API needs real LTX packages and model assets to validate. The pinned commit predates LTX's Transformers-v5 adaptation, so it may not install alongside ModelOpt'stransformers>=5.5; the pin documents the API the example was written against, not a verified combination.Usage
Testing
Pre-commit passed. Not run: no LTX packages or assets were available, so neither the filter nor the pin has been exercised. No test added (it needs the LTX packages).
Before your PR is "Ready for review"
CONTRIBUTING.md: N/AAdditional Information
NVBug 6932665.
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation