Skip to content

[OMNIML-6179] [3/11] Run manual-marked tests on nightly and on-demand GPU runs #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shengliangxu merged 4 commits into from
Oct 21, 2026
Merged

[OMNIML-6179] [3/11] Run manual-marked tests on nightly and on-demand GPU runs #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25c7693
Run the tests marked release on the nightly and on-demand gpu runs
shengliangxu Oct 9, 2026
98cd4e9
Run the real-weights Megatron MMLU test only with --run-release
shengliangxu Oct 9, 2026
f17420c
Run the gated Nemotron v3 dataset smoke test only on the nightly
shengliangxu Oct 10, 2026
df46387
Use the manual marker for the nightly-only GPU tests
shengliangxu Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/gpu_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ jobs:
# sys.monitoring records the same lines as the default C tracer at a fraction of the
# overhead on import-heavy worker processes. Needs Python 3.12+.
COVERAGE_CORE: sysmon
# Tests marked `manual` (real-weight downloads and the like) run on nightly and on-demand
# runs, as in the unit tests, not on pull requests (copy-pr-bot runs those as `push`).
PYTEST_ADDOPTS: ${{ github.event_name != 'push' && '--run-manual' || '' }}
run: |
# Use `python3` (the vllm image has no `python` on PATH)
python3 -m pip install nox && nox -s ${{ matrix.example }}
Expand Down
3 changes: 3 additions & 0 deletions tests/gpu/torch/utils/test_dataset_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ def qwen3_tokenizer():
return tokenizer


@pytest.mark.manual(
reason="Streams the 7 gated Nemotron v3 datasets; runs on the nightly schedule."
)
def test_get_dataset_dataloader_nemotron_v3_chat_template(qwen3_tokenizer):
if not get_token():
pytest.skip(
Expand Down
3 changes: 3 additions & 0 deletions tests/gpu_megatron/torch/utils/plugins/test_utils_megatron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ def _test_megatron_generate_and_mmlu(rank, size, parallelism):
assert 0.36 < megatron_mmlu(model, tokenizer, fraction=0.1, batch_size=16) < 0.39


@pytest.mark.manual(
reason="Real Qwen3-0.6B weights and a 1.2-1.5 GB download; run with --run-manual."
)
@pytest.mark.parametrize("parallelism", ["tp", "pp", "cp", "dp"])
def test_megatron_generate_and_mmlu(dist_workers, parallelism, num_gpus):
if num_gpus == 1 and parallelism != "tp":
Expand Down
Loading