Repository navigation
Conversation
…38.1 The trtllm (gpt-oss) example test has failed since datasets 5.1.0 was released on 2026-10-05, on PRs and on main's nightly run. Installing the example's requirements upgrades datasets to 5.1.0, which needs huggingface_hub>=1.31, so pip moves hub from the image's 1.16.1 to 1.33.0. trackio<0.21 resolves to 0.20.2, which imports CommitOperationAdd from huggingface_hub.hf_api, and hub 1.32.0 stopped exporting it there. trl imports trackio when it writes the model card at the first checkpoint, so sft.py crashes even with --report_to none. The <0.21 cap came from #1390, when the example still ran on transformers 4.x and newer trackio needed huggingface_hub>=1.0. Since #1746 the example requires transformers>=5.3, which itself requires huggingface_hub>=1.3, so the cap no longer protects anything. 0.38.1 is the first trackio release that imports CommitOperationAdd from the top-level package. Pinning datasets<5.1 instead would only fix CI, because the image ships hub 1.16.1. A fresh install still resolves huggingface_hub 1.33.0 with trackio 0.20.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe GPT-OSS example now requires ChangesGPT-OSS dependency update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is established for this requirement update; normal checks can proceed. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
=======================================
Coverage 69.19% 69.19%
=======================================
Files 620 620
Lines 69654 69654
=======================================
Hits 48197 48197
Misses 21457 21457
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
fixed in #2649 , closing this PR |
What does this PR do?
Type of change: Bug fix
Replaces the stale
trackio<0.21cap inexamples/gpt-oss/requirements.txtwithtrackio>=0.38.1. This fixes thetrtllm (gpt-oss)example test, which feeds the requiredexample-pr-required-check.Root cause.
datasets5.1.0 was released on 2026-10-05 and requireshuggingface_hub>=1.31. Installing the example's requirements now upgrades hub in the TRT-LLM image from 1.16.1 to 1.33.0.trackio<0.21resolves to 0.20.2, which importsCommitOperationAddfromhuggingface_hub.hf_api, and hub 1.32.0 stopped exporting it there. trl imports trackio when it writes the model card at the first checkpoint, sosft.pycrashes even with--report_to none:Main's nightly example run on 2026-10-06 fails the same way.
Why a floor instead of the cap. The cap came from #1390. At that time the example still supported transformers 4.x (hub < 1.0), and newer trackio required hub >= 1.0. Since #1746 the example requires
transformers>=5.3, which itself requireshuggingface_hub>=1.3, so the cap no longer protects anything. 0.38.1 is the first trackio release that importsCommitOperationAddfrom the top-level package.Why not pin
datasets<5.1. #2666 does that for the tf_min unit env. Here it would only make CI pass, because the image ships hub 1.16.1. A freshpip install -r examples/gpt-oss/requirements.txtstill resolves hub 1.33.0 with trackio 0.20.2 and hits the same error.Usage
No API change.
Testing
pip install -e ".[hf,dev-test]", the example requirements, thenpytest tests/examples/gpt-oss) innvcr.io/nvidia/tensorrt-llm/release:1.3.0rc22. It matches the CI image (rc20) on transformers, datasets, accelerate and peft.test_gpt_oss_sft_toyfails. It resolves datasets 5.1.0, hub 1.33.0 and trackio 0.20.2, the same as CI.--run-release, as in CI.report_to: trackio. With that setting andtrackio_space_id: null,sft.pytrains, logs to the local trackio store, writes the model card and saves the model.Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: N/A (existing dependency, new version bound)test_gpt_oss_sft_toy)Additional Information
This is a companion to #2666, which fixes the tf_min unit job for the same
datasetsrelease. Open PRs pick up the fix once they merge main, for example #2589.🤖 Generated with Claude Code
Summary by CodeRabbit