Skip to content

Count only added lines toward the PR size budget in AGENTS.md #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjluo-nv merged 2 commits into from
Oct 1, 2026
Merged

Count only added lines toward the PR size budget in AGENTS.md #2616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cd0aa0
Count only added lines toward the PR size budget in AGENTS.md
cjluo-nv Oct 1, 2026
8b65cf2
Exclude tests and docs from the PR size budget in AGENTS.md
cjluo-nv Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ These instructions apply to AI-assisted work in this repository.

## Sizing and splitting PRs

- **Keep each PR that goes up for review under ~500 changed lines of source.**
- **Keep each PR that goes up for review under ~500 added lines of source.**
Large PRs stall in review; exceed the budget only when the change genuinely
cannot be split — a mechanical rename, generated files, or a self-contained
drop such as a new example or a new model/backend that has no working
intermediate state. Check the size with `git diff --stat <base>...HEAD`
intermediate state. Deletions, tests, and docs don't count; check the
insertions from `git diff --shortstat <base>...HEAD -- . ':!tests' ':!docs'`
before opening.
- **Propose the split before opening an oversized PR.** When the work in flight
is already over budget, offer a series of smaller PRs and, once the user
Expand Down
Loading