fix: address review feedback for submit-only migration - #1383
Open
mckornfield wants to merge 2 commits into
Open
fix: address review feedback for submit-only migration#1383mckornfield wants to merge 2 commits into
mckornfield wants to merge 2 commits into
Conversation
Clean up incomplete run→submit search/replace leftovers in docs and author skills, restore critical submit CLI regression tests, and fix invalid submit_remote(sdk=...) examples after rebasing onto main. Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
mikeknep
reviewed
Aug 18, 2026
Comment on lines
+34
to
+36
| The same configuration source is used with `submit`. Resource choices determine whether it is compatible with NeMo Services execution; see [Execution Modes](/documentation/design-synthetic-data/execution-modes). | ||
|
|
||
| `run` executes the Data Designer workload locally, in the CLI process. This can be fully local, but it is not an offline-only mode. A local run can still use the Files API, Secrets API, and Inference Gateway API from a running NeMo Services cluster when the configuration references the corresponding resources. | ||
| ## Submit Versus Platform Execution |
Contributor
There was a problem hiding this comment.
These don't make sense semantically
| <a id="data-designer-cli"></a> | ||
|
|
||
| The NeMo Data Designer plugin adds the `nemo data-designer` command group. Use it to execute Data Designer workloads locally in the CLI process or submit them to NeMo Services. | ||
| The NeMo Data Designer plugin adds the `nemo data-designer` command group. Use it to submit preview and create workloads to NeMo Services. |
Contributor
There was a problem hiding this comment.
Probably makes more sense something like...
Use it to generate high-quality synthetic data on NeMo Platform.
(Side note, I see "NeMo Services" already exists... is that a legit proper noun?)
Comment on lines
-43
to
-44
| | `preview submit` | Local CLI process | Optional | | ||
| | `create submit` | Local CLI process | Optional | |
Contributor
There was a problem hiding this comment.
lol at this table as it exists on the target branch, just totally borked. But also this entire table is pointless now, since the platform services (again that "NeMo Services" noun!) are always required.
Contributor
…iders Clarify that local file/DataFrame seeds remain library-valid but not on the platform path, and that remote validate/submit is IGW-provider-only. Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.