feat(evaluator): Add dedicated Gym task image for agent evaluation - #1366
Closed
JashG wants to merge 11 commits into
Closed
feat(evaluator): Add dedicated Gym task image for agent evaluation#1366JashG wants to merge 11 commits into
JashG wants to merge 11 commits into
Conversation
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
The rebase onto main's promptless-row handling (which independently touched discover_gym_tasks) surfaced tests still asserting gym_row lives under inputs. It moved to metadata earlier in this branch, since the wire-facing TaskInputs DTO only recognizes `instruction` and has nowhere else for an arbitrary dataset row to travel through a submitted job spec. Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
15 tasks
JashG
force-pushed
the
jgulabrai/AALGO-494-gym-integration-tests
branch
from
August 18, 2026 17:51
4a722ca to
7d26389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOTE: Target branch is set to #1315 as this is a follow-up to that PR.
Gym agent evaluations currently depend on a CI-specific variant of the shared CPU task image. This PR replaces it with a dedicated, production-shaped
nmp-gym-tasksimage that isolates Gym and Ray dependencies while remaining CI-only (i.e. only built and used for e2e tests in CI).Changes
Gym task image
nmp-gym-tasksimage based onnmp-cpu-tasksthat installs Gym and Ray into an isolated/opt/gym-venv.Evaluator routing
GymRunnerTargetevaluations rout tonmp-gym-tasks, all others route tonmp-cpu-tasks.NEMO_EVALUATOR_GYM_TASKS_IMAGEfor overriding the fully qualified Gym image.CI and validation
tiktoken.nmp-cpu-tasks-gym-e2eimage and tag-alias workflow.Dependency maintenance
Common Patterns with Customizer Images
Customizer also generates training images with Gym as a dependency. I identified a few common patterns that made sense to follow in this PR:
runtimestage from a cache-onlysmoke-teststage.docker-bake.hcl.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
flox -q activate -- actionlint .github/workflows/ci.yaml— passed.docker buildx bake nmp-gym-tasks-smoke-test— passed; importednemo-gym 0.5.0,ray 2.57.0, andtiktoken 0.13.0.