feat(experimentalist): add Harbor examples - #1050
Open
ngoncharenko wants to merge 4 commits into
Open
Conversation
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
ngoncharenko
marked this pull request as ready for review
August 3, 2026 21:27
ngoncharenko
force-pushed
the
ngoncharenko/aalgo-312-examples
branch
from
August 3, 2026 21:27
64a10b5 to
709a3ce
Compare
ngoncharenko
force-pushed
the
ngoncharenko/aalgo-312-wire-eval-into-optimizer
branch
from
August 4, 2026 18:45
a4c72b8 to
093d1fb
Compare
ngoncharenko
force-pushed
the
ngoncharenko/aalgo-312-wire-eval-into-optimizer
branch
2 times, most recently
from
August 14, 2026 23:59
756b7f2 to
1406607
Compare
Base automatically changed from
ngoncharenko/aalgo-312-wire-eval-into-optimizer
to
main
August 16, 2026 18:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's a follow up for this thread: #955 (comment)
hello-harbor-agentexample with local train and validation tasks, exact-output verifiers, traces, and an optimizer profileharbor_native/harbor_evaluatorA/B workflowWhy this is separate
This keeps the documentation, examples, and smoke tests independently reviewable and reversible from the evaluator implementation, as requested in this review comment.
The new hello example is also a fast smoke-test path:
force_rerunStack
This PR targets #955 because the docs, configuration, and A/B tests intentionally reference the
harbor_evaluatorimplementation introduced there. Once #955 lands, this becomes an examples-only follow-up tomain.Verification
uv run --frozen pytest plugins/nemo-experimentalist/tests/experimentalist/test_evaluator_harbor_ab_e2e.py plugins/nemo-experimentalist/tests/experimentalist/test_hello_example_baseline.py plugins/nemo-experimentalist/tests/test_e2e_helper_defaults.py -q— 17 passeduv run --frozen ruff check plugins/nemo-experimentalist/examples plugins/nemo-experimentalist/tests/experimentalist/test_evaluator_harbor_ab_e2e.py plugins/nemo-experimentalist/tests/experimentalist/test_hello_example_baseline.py plugins/nemo-experimentalist/tests/test_e2e_helper_defaults.pyuv run --frozen ruff format --check plugins/nemo-experimentalist/examples plugins/nemo-experimentalist/tests/experimentalist/test_evaluator_harbor_ab_e2e.py plugins/nemo-experimentalist/tests/experimentalist/test_hello_example_baseline.py plugins/nemo-experimentalist/tests/test_e2e_helper_defaults.pygit diff --checkRefs AALGO-312