chore(ci): run proxy benchmark manually - #491
Conversation
Signed-off-by: Elyas Mehtabuddin <emehtabuddin@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe performance workflow was renamed to indicate manual execution. Automatic pull request and ChangesPerformance workflow
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This PR limits the proxy benchmark to manual runs without introducing a concrete correctness or production risk. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Every pull request and
mainpush starts the proxy benchmark. The latest post-merge run spent 51 minutes waiting for a runner and then occupied that runner for four minutes:Run: https://github.com/NVIDIA-NeMo/Switchyard/actions/runs/32309422644
Fix
The workflow now runs only when someone selects
Run workflow. This removes the proxy benchmark from automatic pull-request andmainCI while keeping the same AIPerf inputs available for manual measurements.The downside is that CI no longer runs this performance check automatically. A developer must start it when a routing or proxy change needs performance evidence.
Before and after
The required
CI SuccessandDCOchecks are unchanged.Testing
Both commands pass.
Summary by CodeRabbit