Fix SBNoiseSchedule t_max accessors#15841
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
SBNoiseSchedulet_maxaccessors so they no longer crash on access and so internalt_maxcalculations follow the caller's device and dtype.Root cause
alpha_t_maxandsigma_t_maxwere buildingt_maxwithalpha.deviceinside property scope, wherealphawas undefined. That made both accessors raiseNameErroras soon as they were called.What changed
_time_max_like()helper plusalpha_t_max_like()andsigma_t_max_like()accessorsalpha_t_maxandsigma_t_maxproperties, but route them through the shared helperalpha_bar_from_alpha()andsigma_bar_from_sigma()sot_maxstays aligned with the reference tensor's device and dtypeValidation
uv run pytest tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.py -k t_max_accessors -vuv run pytest tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.py -vuv run --with black==24.10.0 black --check nemo/collections/audio/parts/submodules/schroedinger_bridge.py tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.pyuv run isort --check-only nemo/collections/audio/parts/submodules/schroedinger_bridge.py tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.py