Fix AIS subprocess lifetime when opening datastore objects#15837
Open
fallintoplace wants to merge 1 commit into
Open
Fix AIS subprocess lifetime when opening datastore objects#15837fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
c3a6bf5 to
6f85e2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Fix
open_datastore_object_with_binary()so AIS-backed file objects stay usable after the helper returns.Collection: Common
Changelog
with subprocess.Popen(...)return path with a small stream wrapper that owns the AIS subprocessUsage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
pytestin this checkout because the active interpreter is missing the project test dependencies, but I did add focused unit coverage and exercised the changed subprocess path with a direct smoke check.