Disable CLI comprehension evaluation#555
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PythonicParser.parse_value()parse_comprehension()reject comprehension input instead of executing iteval(...)Why
CLI config values are user-controlled strings. The previous comprehension path parsed the AST and then executed list, dict, and set comprehensions through raw
eval(...), which allowed arbitrary code execution from CLI input.Impact
Comprehension syntax is no longer supported in CLI values. Suspicious comprehension-looking strings now remain inert unless the caller handles them explicitly, and direct calls to
parse_comprehension()fail with a clear error.Checks
uv run -- pytest test/cli/test_cli_parser.pyuv run --group lint -- ruff check nemo_run/cli/cli_parser.py test/cli/test_cli_parser.py