Fix docker scheduler state aggregation#554
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PersistentDockerScheduler.describe()so any failed container marks the app asFAILEDSUCCEEDEDonce every container has reported and all of them succeededWhy
The previous aggregation logic treated the whole app as successful as soon as it saw any terminal state and any success. That misreported mixed states like
[SUCCEEDED, FAILED]asSUCCEEDED, and it could also report[SUCCEEDED, RUNNING]as finished too early.Impact
Docker-backed jobs now keep polling while some containers are still running, and they surface a failure as soon as any container fails.
Checks
uv run -- pytest test/run/torchx_backend/schedulers/test_docker.py -k aggregates_container_statesuv run --group lint -- ruff check nemo_run/run/torchx_backend/schedulers/docker.py test/run/torchx_backend/schedulers/test_docker.pyNotes
The full Docker scheduler test file still expects a live Docker daemon in this local environment, so validation here is focused on the regression coverage added in this change.