feat: R3 gym notq router replay#2915
Open
zyzhou5 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
/ok to test 763fb26 |
763fb26 to
c289b97
Compare
Contributor
Author
|
/ok to test c289b97 |
Contributor
Author
|
/ok to test df70c93 |
df70c93 to
f594c2d
Compare
Contributor
Author
|
/ok to test f594c2d |
ZhiyuLi-Nvidia
previously approved these changes
Jun 25, 2026
ZhiyuLi-Nvidia
left a comment
Contributor
There was a problem hiding this comment.
Just 2 nit.
LGTM.
9c00c8d to
3879443
Compare
Contributor
Author
|
/ok to test 3879443 |
Contributor
Author
|
/ok to test f15074c |
f15074c to
338f8fc
Compare
Contributor
Author
|
/ok to test 338f8fc |
Contributor
Author
|
/ok to test 20f7389 |
Contributor
Author
|
/ok to test fe5f434 |
Contributor
Author
|
/ok to test 2ff1ffc |
Signed-off-by: Zeyu Zhou <zezhou@nvidia.com>
Signed-off-by: Zeyu Zhou <zezhou@nvidia.com>
Signed-off-by: Zeyu Zhou <zezhou@nvidia.com>
Signed-off-by: Zeyu Zhou <zezhou@nvidia.com>
2ff1ffc to
c25a0bf
Compare
Contributor
Author
|
/ok to test c25a0bf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds no-TQ async Gym path support for R3 router replay.
When
policy.router_replay.enabled=true, async Gym rollouts now request routed expert indices from Gym, validate that they are present, and convert them into Nemo-RL message logs. The routed expert indices are sliced across prompt and generation tokens for each Gym model call so the existing R3 training path can consume them.This also updates the async OpenAI-compatible vLLM endpoint to return routed expert indices in chat response messages when requested.