fix(slime): support rollout_id sample grouping - #53
Open
YolandaLyj wants to merge 1 commit into
Open
Conversation
Signed-off-by: liuyujia17 <liuyujia17@jd.com>
YolandaLyj
force-pushed
the
codex/fix-slime-sample-id-compat
branch
from
August 20, 2026 03:34
ba6d4bb to
358324f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Samples with the trajectory-id field exposed by the installed revisionrollout_idfor newer Slime revisions while retaininggroup_idcompatibility for the v0.3.0 tagBackground
The Slime v0.3.0 tag renamed
rollout_idtogroup_id, but this was reverted shortly afterward:group_id: THUDM/slime@a3c5462rollout_id: THUDM/slime@44d29eeAs a result, the current bridge fails with
TypeError: unexpected keyword argument 'group_id'when used with the Slime revision pinned by newer images/checkouts.This checks the actual
Sampledataclass fields instead of package metadata because image builds can report version0.3.0while containing the post-revertrollout_idschema.Tests
Also passed Ruff and
git diff --check.