Skip to content

fix(slime): support rollout_id sample grouping - #53

Open
YolandaLyj wants to merge 1 commit into
NVIDIA-NeMo:stablefrom
YolandaLyj:codex/fix-slime-sample-id-compat
Open

fix(slime): support rollout_id sample grouping#53
YolandaLyj wants to merge 1 commit into
NVIDIA-NeMo:stablefrom
YolandaLyj:codex/fix-slime-sample-id-compat

Conversation

@YolandaLyj

Copy link
Copy Markdown

Summary

  • construct Slime Samples with the trajectory-id field exposed by the installed revision
  • prefer rollout_id for newer Slime revisions while retaining group_id compatibility for the v0.3.0 tag
  • use the same compatibility order when grouping samples during reward post-processing
  • document and test both schemas

Background

The Slime v0.3.0 tag renamed rollout_id to group_id, but this was reverted shortly afterward:

As a result, the current bridge fails with TypeError: unexpected keyword argument 'group_id' when used with the Slime revision pinned by newer images/checkouts.

This checks the actual Sample dataclass fields instead of package metadata because image builds can report version 0.3.0 while containing the post-revert rollout_id schema.

Tests

29 passed in 0.43s

Also passed Ruff and git diff --check.

Signed-off-by: liuyujia17 <liuyujia17@jd.com>
@YolandaLyj
YolandaLyj force-pushed the codex/fix-slime-sample-id-compat branch from ba6d4bb to 358324f Compare August 20, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant