fix: mark None-default parameters as Optional in vLLMExporter - #724
Open
andrewwhitecdw wants to merge 2 commits into
Open
fix: mark None-default parameters as Optional in vLLMExporter#724andrewwhitecdw wants to merge 2 commits into
andrewwhitecdw wants to merge 2 commits into
Conversation
Several arguments in vLLMExporter.export and vLLMExporter.forward use None as a default but were annotated as non-optional str/int. This causes type-checker warnings and violates the documented signatures. Annotate them as Optional. Adds a static regression test that asserts every parameter with a None default in these methods is Optional. Signed-off-by: Andrew White <andrewh@cdw.com>
andrewwhitecdw
requested review from
athitten,
meatybobby,
oyilmaz-nvidia and
pthombre
as code owners
July 24, 2026 16:00
Contributor
Author
|
Closing after multiple repair attempts: original patch no longer applies or auditor feedback remains unaddressed. |
andrewwhitecdw
deleted the
andrewwhitecdw/fix/vllm-exporter-optional-hints
branch
August 2, 2026 23:57
andrewwhitecdw
restored the
andrewwhitecdw/fix/vllm-exporter-optional-hints
branch
August 17, 2026 20:30
Contributor
Author
|
script closed on accident |
Contributor
|
/ok to run 637a7bf |
Contributor
|
/ok to test 637a7bf |
oyilmaz-nvidia
enabled auto-merge (squash)
August 18, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
vLLMExporter.exportandvLLMExporter.forwarddeclare several parameters with a default ofNonebut annotate them as non-optionalstrorint(e.g.,tokenizer: str = None). This misrepresents the API and triggers type-checker warnings.Fix
Annotate all
None-default parameters asOptional[...].Test
Added a static regression test in
tests/unit_tests/export/test_vllm_exporter.pythat asserts every parameter defaulting toNonein these two methods is atyping.Union(i.e.,Optional).Verification
python -m py_compile nemo_export/vllm_exporter.py tests/unit_tests/export/test_vllm_exporter.pypasses.