fix: allow None dynamic_axes in OnnxLLMExporter.export - #723
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix: allow None dynamic_axes in OnnxLLMExporter.export#723andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
andrewwhitecdw
requested review from
athitten,
meatybobby,
oyilmaz-nvidia and
pthombre
as code owners
July 24, 2026 15:57
OnnxLLMExporter._export_to_onnx unpacked dynamic_axes_input and dynamic_axes_output
directly with {**x, **y}, which raised TypeError when either argument
was left as the default None. Fall back to empty dicts so callers can
omit dynamic axes without crashing.
Adds a unit test that mocks torch.onnx.export and verifies the call
succeeds with dynamic_axes_input=None and dynamic_axes_output=None.
Signed-off-by: Andrew White <andrewh@cdw.com>
andrewwhitecdw
force-pushed
the
andrewwhitecdw/fix/onnx-dynamic-axes-none
branch
from
July 26, 2026 04:13
3048213 to
95e727b
Compare
oyilmaz-nvidia
approved these changes
Aug 18, 2026
Contributor
|
/ok to test 95e727b |
oyilmaz-nvidia
enabled auto-merge (squash)
August 18, 2026 22:37
oyilmaz-nvidia
left a comment
oyilmaz-nvidia
left a comment
Contributor
There was a problem hiding this comment.
Linting issues need to be fixed before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix + regression test for None dynamic_axes handling.