fix: use min_output_len value in query_llm inputs - #721
Open
andrewwhitecdw wants to merge 1 commit into
Open
Conversation
query_llm filled the min_output_len input with max_output_len, so the minimum length request was ignored and the maximum length was used for both. Updates the existing test to verify min_output_len and max_output_len are passed as distinct values. Signed-off-by: Andrew White <andrewh@cdw.com>
andrewwhitecdw
requested review from
athitten,
meatybobby,
oyilmaz-nvidia and
pthombre
as code owners
July 24, 2026 14:29
oyilmaz-nvidia
approved these changes
Aug 18, 2026
Contributor
|
/ok to test d1a5589 |
oyilmaz-nvidia
enabled auto-merge (squash)
August 18, 2026 22:41
oyilmaz-nvidia
left a comment
oyilmaz-nvidia
left a comment
Contributor
There was a problem hiding this comment.
Linting issues need to be fixed before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
query_llmfilled themin_output_leninput withmax_output_len, so the minimum-length request was ignored and the maximum length was used for both.Fix
Use
min_output_lenwhen building themin_output_leninput array.Test
Updated
TestNemoQueryLLMPyTorch::test_query_llm_with_min_output_lento verifymin_output_lenandmax_output_lenare passed as distinct values.Verification
ruff check nemo_deploy/llm/query_llm.py tests/unit_tests/deploy/test_query_llm.pyandruff format --check ...pass.