Skip to content

Sign Parabricks skill - #51

Merged
ohadmo merged 24 commits into
mainfrom
parabricks-skill
Oct 14, 2026
Merged

ohadmo merged 24 commits into
mainfrom
parabricks-skill

Conversation

@ohadmo

@ohadmo ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai

@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium impact] The changes since the previous review appear safe to merge.

Summary

Publishes the Parabricks skill with updated command guidance, runtime checks, STAR translation, and evaluation coverage.

Since the previous review:

  • STAR arguments can now produce a reviewable Parabricks RNA command draft.
  • Runtime checks now use a Bash helper and offer separate opt-in container probes.
  • The Parabricks guide now connects tool choice, shared options, and command examples.
  • The packaged Parabricks skill now includes refreshed evaluation and release records.

No new actionable findings were accepted. Previous threads were unnumbered, so they remain context rather than entries in previousFindings.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Parabricks guidance and helpers] --> B[Distributed skill]
  C[18 evaluation tasks] --> D[Benchmark and skill card]
  D --> B
  B --> E[Signed file hashes]
Loading

Reviews (26) · Last reviewed commit: "Attach NVSkills validation signatures" · Reviewed by Greptile

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/skill-card.md Outdated
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread skills/bionemo-agent-toolkit/skills/parabricks/SKILL.md
Comment thread library-skills/parabricks/SKILL.md Outdated
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/BENCHMARK.md Outdated
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread library-skills/parabricks/evals/evals.json Outdated
Comment thread library-skills/parabricks/references/runtime-environment.md
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/skill-card.md Outdated
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread skills/bionemo-agent-toolkit/skills/parabricks/skill-card.md Outdated
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread skills/bionemo-agent-toolkit/skills/parabricks/skill.oms.sig Outdated
svc-nvskills-signing and others added 2 commits October 2, 2026 19:07
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@ohadmo

ohadmo commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread library-skills/parabricks/scripts/translate_star_to_parabricks.py Outdated
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/skill-card.md Outdated
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/BENCHMARK.md Outdated
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/BENCHMARK.md Outdated
- Update tool references and command conventions for Parabricks 4.7.1
- Improve planning triggers, option translation, and input safeguards
- Replace the Python readiness helper and adapt tests and eval fixtures

Signed-off-by: Angel Pizarro <apizarro@nvidia.com>
…s-skill

Signed-off-by: Angel Pizarro <apizarro@nvidia.com>
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/parabricks/SKILL.md Outdated
Comment thread library-skills/parabricks/scripts/check_parabricks_runtime.sh Outdated
Comment thread skills/bionemo-agent-toolkit/skills/parabricks/BENCHMARK.md Outdated
@greptile-apps

This comment has been minimized.

@ohadmo

ohadmo commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread skills/bionemo-agent-toolkit/skills/genomics-workflow-acceleration/skill-card.md Outdated
Restore genomics-workflow-acceleration source metadata and readiness guidance to the main branch versions. Those changes are now handled in a separate PR, so this branch should validate only the Parabricks skill.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Comment thread library-skills/parabricks/references/shared-options.md Outdated
@ohadmo

ohadmo commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Comment thread library-skills/parabricks/scripts/check_parabricks_runtime.sh
@ohadmo

ohadmo commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@ohadmo

ohadmo commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@ohadmo
ohadmo merged commit 3665dfb into main Oct 14, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants