Repository navigation
Conversation
The accept loop served each socket with Nagle on. A response that hyper writes as a head and then a body holds the body until the client ACKs the head, and a Linux client delays that ACK by 40 ms. Every request whose response went out in two writes paid it. Measured on the Ravel MetricsBench ci stack (NOFireAI/ravel issue 3561): a warm selector query took 50.3 to 50.9 ms against s3s-fs, and 9.3 to 9.6 ms with quickack set in the client's network namespace. A tcpdump of port 9000 showed one 40.4 to 41.0 ms gap per query, each after a 204-byte segment from s3s-fs and ended by the client's ACK. A socket that refuses the option is served without it. Signed-off-by: Panagiotis Moustafellos <pmoust@nofire.ai>
Member
Author
|
Validation done; proposed upstream as s3s-project#1017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation only; upstream port of the ravel.2 TCP_NODELAY commit.