[Config | Dace] Force usage of FV3_DACEMODE for orchestration#184
Open
FlorianDeconinck wants to merge 2 commits intoNOAA-GFDL:developfrom
Open
[Config | Dace] Force usage of FV3_DACEMODE for orchestration#184FlorianDeconinck wants to merge 2 commits intoNOAA-GFDL:developfrom
FV3_DACEMODE for orchestration#184FlorianDeconinck wants to merge 2 commits intoNOAA-GFDL:developfrom
Conversation
Use the defered initialization to push a DaceConfig which is controlled by FV3_DACEMODE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current status of the configuration for orchestration is very fragile. This PR comes after a bad change on the default fixed here. We will now force the usage of
FV3_DACEMODEby reseting the DaceConfig when we have the Communicator ready.Details:
DaceConfigvia dict (unusuable)How Has This Been Tested?
Ran orchestrated c12 from config
Checklist: