Skip to content

[Config | Dace] Force usage of FV3_DACEMODE for orchestration#184

Open
FlorianDeconinck wants to merge 2 commits intoNOAA-GFDL:developfrom
FlorianDeconinck:fix/dace_config_initialization
Open

[Config | Dace] Force usage of FV3_DACEMODE for orchestration#184
FlorianDeconinck wants to merge 2 commits intoNOAA-GFDL:developfrom
FlorianDeconinck:fix/dace_config_initialization

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

The current status of the configuration for orchestration is very fragile. This PR comes after a bad change on the default fixed here. We will now force the usage of FV3_DACEMODE by reseting the DaceConfig when we have the Communicator ready.

Details:

  • Remove DaceConfig via dict (unusuable)
  • Use the deffered initialization to push a DaceConfig which is controlled by FV3_DACEMODE

How Has This Been Tested?

Ran orchestrated c12 from config

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Use the defered initialization to push a DaceConfig which is controlled by FV3_DACEMODE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant