Repository navigation
Fix the soil Gaussian increment for the new oops - #2317
Merged
Merged
Conversation
oops 80bf6ba6, brought in by #2312, renamed the StructuredGridWriter key "variables to output" to "variables". #2312 renamed it in the aerosol Gaussian increment template but not in the soil one, so the soil variational analysis aborts in every rank with "Undefined variable: 'variables'" when it sets up its Gaussian increment output (global-workflow C96C48_ufs_hybatmsoilDA).
Contributor
|
Thank you @shlyaeva for this fix. If @tsga and you are fine with the change, I'll merge today. @ClaraDraper-NOAA , it sounds like we should add a subset of jobs from If someone from the Land DA team can list the cycles and jobs from accordingly. GDASApp issue #2318 was opened to discuss and document the addition of a soil DA test to GDASApp CI. |
9 of 23 tasks
tsga
approved these changes
Nov 6, 2026
RussTreadon-NOAA
added
the
hera-GW-RT
emcbot
added
hera-GW-RT-Running
CI Run Summary for PR #2317 (Commit: 5685ab8)Automated GW-GDASApp Testing Results: CI Status: Passed |
emcbot
added
hera-GW-RT-Passed
Contributor
|
Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
oops 80bf6ba6 (brought in by #2312) renamed the
StructuredGridWriterkeyvariables to outputtovariables. #2312 renamed it inaero_final_increment_gaussian.yaml.j2but not insoil_final_increment_gaussian.yaml.j2. As a result, the soil variational analysis aborts in every rank withUndefined variable: 'variables'when it sets up its Gaussian increment output.This renames the key in the soil template. Soil is a single-time 3D-Var, so it needs no
times:.Found in global-workflow
C96C48_ufs_hybatmsoilDAon Ursa:gdas_soilanlvarfailed at 2022051512 with GDASApp develop 5017689. GDASApp CI has no soil case, so this was tested by rerunning that task on Ursa with the fix.atm_jjobis ticked only because the CI driver needs at least one test.Companion PRs
None.
Issues
Resolves #NNNN
Automated CI tests to run in Global Workflow