Initial support for set tsig-store-path and set publication-nameserver.#166
Merged
Initial support for set tsig-store-path and set publication-nameserver.#166
set tsig-store-path and set publication-nameserver.#166Conversation
…rver`. To support use of TSIG in Cascade. Lacks RustDocs, man page entries and additional logging.
14 tasks
As Base64 is typically how tooling present/accept TSIG key secret data to/from users. Requires the same change to be made to Cascade too.
…s takes a list of nameservers. Missing bits: checks when remove a TSIG store, checks when adding nameservers.
| .map(Option::Some) | ||
| .map_err(|err| err.to_string()) | ||
| } else { | ||
| Ok(None) |
Member
There was a problem hiding this comment.
Should this be an error? It's a bit confusing if keyset silently ignores a key that is not in the key store.
Member
Author
There was a problem hiding this comment.
I already changed that code locally but was waiting to push. I'll merge and push the updated code as soon as I can.
- Remove unnecessary Result. - Enforce v1 when parsing a persisted key store. - Fail earlier on key name parsing. - Verify that referenced TSIG keys exist in the store. - Include 'hmac-' in the (de)serialized TSIG algorithm name.
Philip-NLnetLabs
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on NLnetLabs/cascade#301 (comment).
To support use of TSIG with
dnst keysetwhen invoked by Cascade, specifically in combination with thednst keysetability to do zone transfers to verify the content of published zones.Adds two "keys" to the key/vaiue pairs supported by the existing
dnst keyset setsubcommand:dnst keyset set tsig-store-path </PATH/TO/TSIG/KEYSTORE/FILE>dnst keyset set publication-nameservers [<NAMESERVER> [<NAMESERVER>...]]This PR does NOT contain manual page updates as the functionality is intended to work with TSIG key store files produced by Cascade and does not (at least not in this PR) add support for creating key store files viaUpdate: @Philip-NLnetLabs and I decided it should be documented, but state the lack of support for actual creating the keystore file if you are using onlydnst keyset.dnst keysetand not Cascade.I tested this manually with the
.chzone which requires a TSIG key to transfer it, with a key store file created by Cascade.