Skip to content

refactor Icinga client to use builder pattern - #50

Open
UiP9AV6Y wants to merge 1 commit into
NETWAYS:mainfrom
UiP9AV6Y:feature/client-options
Open

UiP9AV6Y wants to merge 1 commit into
NETWAYS:mainfrom
UiP9AV6Y:feature/client-options

Conversation

@UiP9AV6Y

Copy link
Copy Markdown
Contributor

using the builder pattern allows configuring individual aspects of the client. this change adds an alternative client constructor function while remaining backwards compatible. the only actual change in behaviour, is the User-Agent header sent to remote endpoints now contains the application name, version, and commit, instead of just the application name.

future changes could add more control options for the client via the configuration.

using the builder pattern allows configuring individual aspects
of the client. this change adds an alternative client constructor
function while remaining backwards compatible. the only actual
change in behaviour, is the `User-Agent` header sent to remote
endpoints now contains the application name, version, and commit,
instead of just the application name.

future changes could add more control options for the client
via the configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant