Repository navigation
Add option to set host check results - #45
Conversation
d1d1995 to
c17b2dc
Compare
c17b2dc to
f7dce6d
Compare
|
Hi @UiP9AV6Y This PR should enable the described use-case. Feel free to test it and give me feedback. Thanks |
UiP9AV6Y
left a comment
There was a problem hiding this comment.
the change looks good overall, just minor nitpicks
|
i did run into an issue while testing the feature against the local docker-compose stack. the bridge sent the following request {
"exit_status": 2,
"plugin_output": "Host down",
"ttl": 0,
"filter": "host.name==\"gaff.bac.test\"",
"type": "Host"
}and received the following response from the Icinga2 API {
"results": [
{
"code": 400,
"status": "Invalid 'exit_status' for Host gaff.bac.test."
}
]
}not sure if my setup is broken or something else is not working as intended. the error is currently not logged; i have opened #46 as a result |
Co-authored-by: Gordon Bleux <33967640+UiP9AV6Y@users.noreply.github.com>
Co-authored-by: Gordon Bleux <33967640+UiP9AV6Y@users.noreply.github.com>
|
@UiP9AV6Y Thanks for the review. You're setup isn't broken it's the exit status mapping for host checks. |
|
can confirm. host objets are now updates based on alerts. i have refactored the docker-compose setup to include an example for a host-check-based alert in a feature branch feel free to cherry pick the commit, otherwise i can make a follow-up PR |
|
Thanks for the feedback. I think this will be the last change for the version v1.1.0. |
Fixes #42