(#21) Release for shared autocomplete #75
Merged
Merged
Conversation
Contributor
Storybook PreviewThis PR includes component changes. A Storybook build was verified successfully. Once merged, the updated Storybook will be deployed to GitHub Pages automatically. |
- Wraps native <input> with USWDS usa-input class - Supports text, email, password, tel, url, number, and search types - Forwards standard input props for controlled/uncontrolled use - Includes unit tests, jest-axe accessibility test, and Storybook stories Closes #27
- Implement ARIA combobox pattern (role, aria-expanded, aria-controls, aria-activedescendant, aria-haspopup, aria-labelledby) - Add synchronous options filtering via `options` prop - Add async data loading via `loadOptions` prop - Add debounced input (configurable via `debounceDelay`) - Add custom option rendering via `renderOption` prop - Add custom label/value extraction via `getOptionLabel`/`getOptionValue` - Add keyboard navigation (ArrowUp/Down, Enter, Escape, Tab) - Add clear button (hidden when disabled or empty) - Add loading state indicator - Add configurable no-results message - Add Autocomplete.module.scss CSS module styling - Add comprehensive unit tests with 90%+ coverage - Add jest-axe accessibility test - Add Storybook stories with 6 story variants - Export from ncids/index.ts barrel - Use useCallback for resolveLabel/resolveValue to fix deps array - Add resolveLabel to controlled value sync effect deps - Change activedescendant → activeDescendant (camelCase) - Remove redundant named export (use export function declaration) - Extract stateful Storybook stories into proper components - Fix ArrowUp: allow de-highlighting from index 0 (→ -1) - Use literal ellipsis character instead of unicode escape - Add test for ArrowUp clearing highlight at first item * Adds styles.d.ts for Autocomplete.scs file * Updates Autocomplete.tsx to use MouseEvent instead of PointerEvent * Adjusts Autocomplete.module.scss styling * Adjusts Autocomplete.test to pass lint tests Closes #21 Initial plan chore: initial plan for Autocomplete component Agent-Logs-Url: https://github.com/NCIOCPL/react-app-shared/sessions/20befcde-a76b-49a2-8a61-fe0075b5fcc5 Co-authored-by: adriancofie <38888889+adriancofie@users.noreply.github.com> feat: implement Autocomplete combobox component - Add Autocomplete.tsx with generic TypeScript interface - Implement ARIA combobox pattern (role, aria-expanded, aria-controls, aria-activedescendant, aria-haspopup, aria-labelledby) - Add synchronous options filtering via `options` prop - Add async data loading via `loadOptions` prop - Add debounced input (configurable via `debounceDelay`) - Add custom option rendering via `renderOption` prop - Add custom label/value extraction via `getOptionLabel`/`getOptionValue` - Add keyboard navigation (ArrowUp/Down, Enter, Escape, Tab) - Add clear button (hidden when disabled or empty) - Add loading state indicator - Add configurable no-results message - Add Autocomplete.module.scss CSS module styling - Add comprehensive unit tests with 90%+ coverage - Add jest-axe accessibility test - Add Storybook stories with 6 story variants - Export from ncids/index.ts barrel Agent-Logs-Url: https://github.com/NCIOCPL/react-app-shared/sessions/20befcde-a76b-49a2-8a61-fe0075b5fcc5 Co-authored-by: adriancofie <38888889+adriancofie@users.noreply.github.com> refactor: address code review feedback for Autocomplete component - Use useCallback for resolveLabel/resolveValue to fix deps array - Add resolveLabel to controlled value sync effect deps - Change activedescendant → activeDescendant (camelCase) - Remove redundant named export (use export function declaration) - Extract stateful Storybook stories into proper components - Fix ArrowUp: allow de-highlighting from index 0 (→ -1) - Use literal ellipsis character instead of unicode escape - Add test for ArrowUp clearing highlight at first item Agent-Logs-Url: https://github.com/NCIOCPL/react-app-shared/sessions/20befcde-a76b-49a2-8a61-fe0075b5fcc5 Co-authored-by: adriancofie <38888889+adriancofie@users.noreply.github.com> fix: remove redundant optional chaining after bounds check in Autocomplete Agent-Logs-Url: https://github.com/NCIOCPL/react-app-shared/sessions/20befcde-a76b-49a2-8a61-fe0075b5fcc5 Co-authored-by: adriancofie <38888889+adriancofie@users.noreply.github.com> (#73) Implement Autocomplete component * Adds styles.d.ts for Autocomplete.scs file * Updates Autocomplete.tsx to use MouseEvent instead of PointerEvent * Adjusts Autocomplete.module.scss styling * Adjusts Autocomplete.test to pass lint tests Closes #73
- Replace the broken CSS-module (Autocomplete.module.scss compiled to `var styles = undefined` and shipped no CSS) with a plain SCSS partial (_autocomplete.scss) forwarded into the bundled stylesheet, using static nci-autocomplete* class names so styles ship in dist/styles/index.css. - Add minChars + minCharsMessage (below-threshold hint). - Add onSubmit + a search button; Enter submits when no option is highlighted. - Add highlightMatch to bold the matched substring, and searchButtonLabel. - Tests (46) and a SearchBox story; add changeset (minor). Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release commit for shared autocomplete