(#21) Add Autocomplete search-box features and fix style packaging#74
Merged
Conversation
Contributor
Storybook PreviewThis PR includes component changes. A Storybook build was verified successfully. Once merged, the updated Storybook will be deployed to GitHub Pages automatically. |
- Replace the broken CSS-module (Autocomplete.module.scss compiled to `var styles = undefined` and shipped no CSS) with a plain SCSS partial (_autocomplete.scss) forwarded into the bundled stylesheet, using static nci-autocomplete* class names so styles ship in dist/styles/index.css. - Add minChars + minCharsMessage (below-threshold hint). - Add onSubmit + a search button; Enter submits when no option is highlighted. - Add highlightMatch to bold the matched substring, and searchButtonLabel. - Tests (46) and a SearchBox story; add changeset (minor). Closes #21
adriancofie
force-pushed
the
ticket/21-autocomplete-css
branch
from
bb21e0c to
0de0270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
var styles = undefinedand shipped no CSS) with a plain SCSS partial (_autocomplete.scss) forwarded into the bundled stylesheet, using static nci-autocomplete* class names so styles ship in dist/styles/index.css.Closes #21