Skip to content

Ticket/5252 press release migration epic#5259

Open
dlescarbeau wants to merge 4 commits into
developfrom
ticket/5252-press-release-migration-epic
Open

Ticket/5252 press release migration epic#5259
dlescarbeau wants to merge 4 commits into
developfrom
ticket/5252-press-release-migration-epic

Conversation

@dlescarbeau

@dlescarbeau dlescarbeau commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Closes Epic:
Closes #5232

Closes Tickets:
Closes #5233 - adds horizontal rule to public use on press releases
Closes #5234 - updates press release type to be wrapped in usa-prose
Closes #5235 - migrates press release body to ncids_full_html and removes lead image from body wrapper (removes the wrapper entirely)
Closes #5264 - updates contact info section to remove phone number and provides new mailto: email link

@dlescarbeau dlescarbeau force-pushed the ticket/5252-press-release-migration-epic branch 3 times, most recently from c6bf34e to 09fa225 Compare June 4, 2026 14:54
@cgdp-management-server

cgdp-management-server Bot commented Jun 8, 2026

Copy link
Copy Markdown

ODE Deployment

Code has been deployed to ODE 1140.

@adrianacastaneda

adrianacastaneda commented Jun 8, 2026

Copy link
Copy Markdown

@dlescarbeau Edit: Everything good to me. Will pass after glossary definition issue gets resolved!

Other the glossary link not working, I found that the Pubmed ID link appears below the citation instead of on the same line. The pubmed link actually isn't on the comp but looking at the article comp, it appears on the same line.

cc: @andyvanavery31

@andyvanavery31 andyvanavery31 requested review from a team, adrianacastaneda and lburack June 9, 2026 14:54
@alinai

alinai commented Jun 9, 2026

Copy link
Copy Markdown

Issue:

  1. Glossified terms getting underline and returning PNF on click:
    https://ncigovcdode1136.prod.acquia-sites.com/news-events/press-releases/2018/press-release-no-date

2."View Infographic" link appearing on ODE on:
https://ncigovcdode1136.prod.acquia-sites.com/news-events/press-releases/2019/brca-exchange
https://ncigovcdode1136.prod.acquia-sites.com/test/press-release-citation-norr

3.We need to fix this page where data-align="center" > appears on the content. It happens on dev-ac as well.
Embedded Video Content Press Release Test Page - NCIDS Styles - NCI

  1. The Contact link should say NIH Press Office. The email address is to the NIH press office; it's no longer NCI Press Office. (cc: @lburack , @andyvanavery31 )

@alinai

alinai commented Jun 9, 2026

Copy link
Copy Markdown

Confirmed with @andyvanavery31:
Font size looks good for Press Release Type and Title
Contact appearing on the right is correct
Spanish Press release does not show any Contact and this is expected
The width difference of the WYSIWYG (CMS side) between Press Release and Article is acceptable.

@lburack

lburack commented Jun 9, 2026

Copy link
Copy Markdown

Issue:

  1. Glossified terms getting underline and returning PNF on click:
    https://ncigovcdode1136.prod.acquia-sites.com/news-events/press-releases/2018/press-release-no-date
    2."View Infographic" link appearing on ODE on:
    https://ncigovcdode1136.prod.acquia-sites.com/news-events/press-releases/2019/brca-exchange
    https://ncigovcdode1136.prod.acquia-sites.com/test/press-release-citation-norr

@alinai - I believe it's displaying "View Infographic" without the actual infographic because that media item isn't on the ODE. I added an infographic that is available on the ODE and it's displaying as expected: https://ncigovcdode1136.prod.acquia-sites.com/test/press-release-citation-norr

@lburack

lburack commented Jun 9, 2026

Copy link
Copy Markdown

The Contact link should say NIH Press Office. The email address is to the NIH press office; it's no longer NCI Press Office. @dlescarbeau @andyvanavery31

@dlescarbeau dlescarbeau force-pushed the ticket/5252-press-release-migration-epic branch 3 times, most recently from c800f08 to c4c76e8 Compare June 10, 2026 17:59
- updates yaml files with ncids_full_html

- updates twig template with new html

- adds analytics tracking for links in the body field

Closes #5235
@dlescarbeau dlescarbeau force-pushed the ticket/5252-press-release-migration-epic branch from c4c76e8 to 47ef19e Compare June 11, 2026 18:11
@KateMashkinaNIH

Copy link
Copy Markdown

passed QA on ODE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants