[DNM] Activate and test pre-commit.ci #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have activated pre-commit.ci app to run in our repo, and this is to test it's doing the right thing.
https://pre-commit.ci/
@davidhassell @bnlawrence @kmuehlbauer @dostuffthatmatters gents, yet another step towards making our repo rather modern, and user-facing - I turned on pre-commit.ci that looks like this when somebody opens a PR https://results.pre-commit.ci/run/github/57862445/1769523801.CpvXywnoSiia7JTvu6TYwg - nice results displayed via a nice GUI; of course, this should be picked up and fixed by the OP of the PR, but there are many reasons why the OP isn't running
pre-commit run -ain their repo. The GHA CI still runs pre-commit since that's still needed for nightly tests etc.NOTE: the actual pytest tests are failing since the CEDA S3 bucket is offline, there is maintenance at JASMIN happening today 🚧