Open
Conversation
- avoid including fs and untildify, just pass in raw streams - uses webpack to bundle to dist/nodewarc.js - expose stream and zlib for further testing with WARCParser - add index.html for testing issues: still getting 'Uncaught Error: invalid distance too far back' from zlib, unrelated to warc parsing (which works well!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows node-warc to be bundled with webpack for use in the browser.
Operations requiring
fsare moved to separate module and a stream is passed in viagetStreamfsanduntildifyare excluded from bundling for the browser.