Add apple as an AuthProvider#70
Open
woat wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| case 'apple': { | ||
| params.set('response_type', 'code%20id_token') | ||
| params.set('scope', 'email') | ||
| params.set('response_mode', 'form_post') |
Collaborator
There was a problem hiding this comment.
I don’t think this response mode is compatible with most apps. We have plans to solve this eventually via a custom endpoint that can do the token exchange but haven’t built it out yet.
Author
Collaborator
There was a problem hiding this comment.
It does, but it doesn’t work with the SDK. I’ll try and grab some resources around how to use it tomorrow and drop them here
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
I'm adding apple based on https://docs.sui.io/guides/developer/cryptography/zklogin-integration#get-jwt
Test plan
I just ran this: