[CLEANUP] Remove redundant test code#1584
Merged
Merged
Conversation
`getAllValues()` only includes values that are `Value` objects. It does not include `string` values. So the list returned was empty, the loop had no iterations, and the `assertSame()` was never called. It doesn't make sense to replace the code with an assertion that `getAllValues()` is returning an empty list, because the `TestCase` is for `Parser`, not `Document`. Besides, there is already an assertion that `red` is set for the string `color` value. Uncovered by PHPStan config change in #1583. This change would also have silenced the same PHPStan warning.
JakeQZ
added
cleanup
testing
|
coverage: 73.324%. remained the same — test/remove-redundant-getvalues into main |
oliverklee
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getAllValues()only includes values that areValueobjects. It does not includestringvalues. So the list returned was empty, the loop had no iterations, and theassertSame()was never called.It doesn't make sense to replace the code with an assertion that
getAllValues()is returning an empty list, because theTestCaseis forParser, notDocument. Besides, there is already an assertion thatredis set for the stringcolorvalue.Uncovered by PHPStan config change in #1583.
This change would also have silenced the same PHPStan warning.