Skip to content

Dect #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yemeen merged 22 commits into from
Sep 2, 2025
Merged

Dect #60

yemeen merged 22 commits into from
Sep 2, 2025

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Aug 29, 2025

implements differentiable ect

Description

created a new class that replaces _compute_directional_transform for the sigmoid version for dect

Motivation and Context

#59

How has this been tested?

test_dect.py for tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x ] My code follows the code style of this project. (make clean)
  • [x ] I have incremented the version number in the pyproject.toml file.
  • [x ] I have added tests to cover my changes.
  • [ x] All new and existing tests passed. (make tests)

yemeen and others added 22 commits March 12, 2025 15:08
@yemeen
Add simplices to embedded graph as k-simplices
51174e5
@yemeen
remove legacy embedding files
a4c31f3
@yemeen
rework embed classes into one, change ect to calculate for arbitrary …
e483f7f 
…dimension, add validation system for complex
@yemeen
rename to ect.py
97333ac
@yemeen
add test coverage for embed_complex class and validation system
5843f4e
@yemeen
Update import statement in __init__.py to ECT module
d109ad1
@yemeen
add tutorial
69f6fef
@lizliz
Got the ect documentation pointing at the right command
4993538
@yemeen
search sorted speedup
e950707
@yemeen
Merge branch 'main' of https://github.com/MunchLab/ect into n-simplex
846af3f
@yemeen
Merge branch 'n-simplex' of https://github.com/MunchLab/ect into n-si…
2f29304 
…mplex
@yemeen
Update EmbeddedCW to EmbeddedComplex in SECT class
076942f
@yemeen
Refactor ECT _compute_directional_transform method
f974559
@yemeen
Convert array-like directions to Directions object
7373ec3
@yemeen
fix tests
24e13f7
@yemeen
fix tutorial and index issue
ffdd97b
@yemeen
Refactor structure and validation in embed_complex.py
efb19f9
@yemeen
add dect to package
7f00700
@yemeen
update docs
548a870
@yemeen
clean up class
83933b7
@yemeen
add tests
1cd8ccc
@yemeen
Bump version to 1.1.1 in pyproject.toml
606c9a0
@yemeen yemeen marked this pull request as ready for review August 29, 2025 23:05
@yemeen yemeen requested a review from lizliz as a code owner August 29, 2025 23:05
lizliz
lizliz approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@lizliz lizliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since we talked about this last week

@yemeen yemeen merged commit fe6e114 into main Sep 2, 2025
3 checks passed
@yemeen yemeen deleted the dect branch September 2, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizliz lizliz lizliz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yemeen @lizliz