Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for ECT computations on general n-faces, embeddings rules, and general speedups.
Description
combines
EmbeddedGraphandEmbeddedCWinto unified classEmbeddedComplex. adds an embedding validation system to allow for out of the box checking for valid embeddings with options of adding custom rules (eg. planar graphs, bounded complexes, etc). cleaned up tutorial documentation.changed our calculation to use
np.searchsortedonce for all thresholds which massively brings down computation times (this was while training a model so results might be better idk)Motivation and Context
want to do higher dimensions
How has this been tested?
new test classes are added
Types of changes
Checklist
make clean)pyproject.tomlfile.make tests)