Fully-featured Primitive resolution shift operations - #75
Draft
timbernat wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
System preparation at arbitrary resolution scales and and CG backmap operations would greatly benefit from mature capability for expanding, retracting, and truncating intermediate scale Primitive within a hierarchy tree. Further, the implementation of expansion provided there is poorly-scalable, taking significant time even for systems on the order of 10k atoms, due to reliance on atomic operations on individual primitives, rather than caching information and making use of larger organizational units within the representation (i.e. avoiding the "deregister -> reregister/relabel -> reconnect to neighbors" path taken now). This was a deliberate choice to facilitate reasoning about the correctness of the program and simplify implementation, but would benefit from more targeted optimization now that it has been tested in example workflows.
Todos
Notable points that this PR has either accomplished or will accomplish.
Primitive.retract(): injects an intermediate level into a hierarchy between a parent Primitive and its children, encoding a partition of those childrenPrimitive.truncate(): add the ability to remove all levels below a given Composite and replace it with an analogous SimplePrimitive.expand()Primitive.flatten()in exporters with topolgoy collection logic (TB: likely an entirely separate PR)Questions
Status