Repository navigation
fix(sessions): /sessions list rendering + delete-flow fixes (port-2262 QA) - #31
Merged
Merged
Conversation
Bug 1 (list breaks past 8th row with 20 sessions): size the Select visible window to the terminal height (rows - 9 for Dialog chrome, min 1) instead of the fixed 5-row default, mirroring the /resume LogSelector pattern that already handles long lists. Regression coverage in sessions-windowing.test.tsx (20-row traversal); upstream sessions.test.tsx untouched. Bug 2 (double-d delete breaks the TUI flow): replace the post-delete disk reload + list remount with a local drop of the deleted entry (the /resume picker delete-flow shape from fork PR #25/#26), keeping the hardened deleteSessionFiles primitive (transcript + sidecars). Confirm dialog, d-d UX, and all user-facing strings unchanged. Per-surface delete primitives: /sessions -> deleteSessionFiles; /resume + /replay pickers + ResumeConversation inline copy -> SDK deleteSession (picker convergence onto deleteSessionFiles remains open as F1).
…path Round 1 only changed the option count; real 200-char session titles still wrapped option rows across lines in the compact two-column layout, exploding frame height past the viewport. Converge the list on the LogSelector flat path: layout=expanded, row-aware window floor((rows-12)/3), whitespace-collapsed width-truncated labels. Tests: new sessions-list-layout.test.tsx 3/3 (0/3 pre-fix).
… parity) The list handler now fires on key.delete as well as 'd' (LogSelector fires onDeleteRequest from key.delete), so the second confirm press may be Delete or d. Hint updated to 'Del or d delete (press twice to confirm)'. Armed cue and Dialog footer untouched. New sessions-delete-key.test.tsx: 4/4 (arm, Del-Del, Del-d, Del-x disarm).
Owner
Author
|
Merging on local evidence per PR #30 standard (repo-wide Actions outage standing — no checks reported on this branch). Accepted risk: CI silent, no remote validation. Local evidence on fix build: sessions-delete-key 4/4, windowing 3/3 RED->GREEN, screens 81/0, build+smoke PASS, plus user visual verification (delete flows fixed, no rendering errors). Merge explicitly authorized by user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QA follow-up to port-2262 (#30): fixes /sessions list rendering + delete flows, user visually verified on fix build.
Root causes + fixes
Local evidence (fix build)
CI note
Repo-wide Actions outage standing — if checks absent/silent, merge on local evidence per PR #30 standard (risk documented in merge comment). If checks run RED on sessions files, do NOT merge.