Add support to two input process method. - #77
Merged
miroslavpojer merged 3 commits intoSep 1, 2026
Merged
Conversation
miroslavpojer
deleted the
feature/76-Lower-minimum-sbt-version-below-1.10
branch
September 1, 2026 14:19
Merged
miroslavpojer
added a commit
that referenced
this pull request
Sep 1, 2026
Bump version 2.4.0 -> 2.5.0 across build files, example projects, integration-test fixtures, and docs. Promote the CHANGELOG [Unreleased] section (sbt 1.x compatibility fix, #76/#77) to [2.5.0] and add fresh [Unreleased] plus link references. Add the sbt-19x fixture to the RELEASE.md version-bump checklist. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2.4.0 of the sbt plugin uses the 3-arg
Command.process(String, State, onParseError)overload,which was added in sbt 1.10.0. On sbt 1.9.x, running
jacocoCleanAll/jacocoReportAllfailswith:
The plugin's README advertises "sbt 1.x", so this is a regression against the documented contract
and blocks adoption in projects that deliberately pin an older-but-supported sbt (which, via sbt
1.10's SIP-51 enforcement, would otherwise cascade into forced
scalaVersion/ semanticdb bumps).Fixes #76.
Root cause
sbt-plugin/src/main/scala/morana/coverage/JacocoFilterPlugin.scalacalls the 3-arg overload inboth aggregate commands:
Verified against sbt sources:
main-command/src/main/scala/sbt/Command.scalaatv1.9.9exposesonly
process(String, State);v1.10.0adds the 3-arg overload and@deprecateds the 2-arg one.Changes
JacocoFilterPlugin.scala— both calls switched to the 2-argCommand.process(String, State)overload, which exists across all sbt 1.x. TheonParseErrorcallback only fires on a malformed command string (not on command-execution failure), and the
2-arg overload still returns a failed state on parse error, so the build still fails as before.
build.sbt— pinnedpluginCrossBuild / sbtVersion := "1.9.0"for thesbtPluginmodule soit compiles against the oldest supported sbt API and cannot silently pick up 1.10+ methods again.
The dev build still runs on the
sbt.versioninproject/build.properties.integration-tests/fixtures/sbt-19x/+integration-tests/test-sbt-19x.sh— new self-containedfixture pinned to
sbt.version=1.9.9. The test asserts the launcher is on sbt 1.9.x, then runssbt clean testand the fulljacocoflow;jacocoReportAllinvokesCommand.process, so aregression to a newer-than-1.9 sbt API fails the test. Picked up automatically by
run-all.sh(the
test-*.shglob), so the existingintegrationCI job runs it with no workflow change.integration-tests/README.md— documented the new fixture and test row.CHANGELOG.md— newUnreleased -> Fixedentry.Compatibility
jacoco-method-filter-sbt_2.12_1.0) continues to serve all sbt 1.xconsumers; plugins resolve under the shared
1.0binary bucket.NoSuchMethodErroris gone.@deprecatedthere but stillpresent and binary-compatible; the build has no fatal-warnings, so it is a non-issue.
Testing
cijob'ssbt testcompiles thesbtPluginmodule against thesbt 1.9.0 jars (via
pluginCrossBuild / sbtVersion), so any accidental use of a newer-than-1.9sbt API now fails CI.
test-sbt-19x.sh(this PR) runs the plugin on an actual sbt 1.9.9 launcher andexercises
jacocoReportAll→Command.processend-to-end — the exactNoSuchMethodErrorpathfrom Lower minimum sbt version below 1.10 (avoid 3-arg Command.process) #76. Runs in the existing
integrationCI job viarun-all.sh.Release notes:
java.lang.NoSuchMethodError: sbt.Command$.process(...)when runningjacocoCleanAll/jacocoReportAll— v2.4.0 had started using the 3-argCommand.processoverload that onlyexists in sbt 1.10.0+.
pluginCrossBuild / sbtVersion), so it can nolonger regress onto newer-than-1.9 sbt APIs. sbt 1.x compatibility is restored; one published
artifact still serves every sbt 1.x version.
Closes #76