Expose backend event handling features#42
Open
Demorome wants to merge 2 commits intoMoonsideGames:mainfrom
Open
Expose backend event handling features#42Demorome wants to merge 2 commits intoMoonsideGames:mainfrom
Demorome wants to merge 2 commits intoMoonsideGames:mainfrom
Conversation
Contributor
Author
|
Marking this as a draft, since I found an issue with my implementation for the Prevent(...)Inputs option: If an input was pressed and PreventInputs is switched on, then later switched off, it might discard the input-released event and leave the input in a pressed-down state, at least until the button is re-pressed and let go. |
Contributor
Author
|
The fix I went with was to just constantly set buttons as non-pressed and deltas to 0 while inputs are prevented. I could do a cached bool check to prevent redundant changes but that didn't seem necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly so anyone can easily use the ImGui SDL_GPU backend's
ProcessEventsto automatically handle all SDL events.For example, my
OnReceiveEventcallback currently looks like:(Using the Hexa ImGui C# port for the ImGui SDL_GPU backend).