Skip to content

Adjust posters on Person Detail page - #219

Open
ADRStudio wants to merge 5 commits into
Moonfin-Client:masterfrom
ADRStudio:Person-Details
Open

Adjust posters on Person Detail page#219
ADRStudio wants to merge 5 commits into
Moonfin-Client:masterfrom
ADRStudio:Person-Details

Conversation

@ADRStudio

Copy link
Copy Markdown

Pull Request

Summary

Adjust the size of the posters on Person Details and sort the posters by date. Adjust positions on person details and set focus to the first poster instead of the favorites.

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Adjusted the sizes of filmography poster on Person Detail Page
  • Sort filmography on Person Detail Page by Premiere Date
  • Adjust the layout of Person Detail Page to correctly show poster labels
  • Removed the Favorite text from Person Detail Page
  • Set initial focus to the first filmography poster on Person Detail Page
  • Removed Official Rating from posters label on Person Detail Screen to avoid overlapping.

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Screenshots (if applicable)

Version 1.5.0 Person Detail page:

image

After proposed modifications:

image

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Removed Official Rating from posters label on Person Detail Screen to avoid overlapping.
Adjusted the sizes of filmography poster on Person Detail Page
Sort filmography on Person Detail Page by Premiere Date
Adjust the layout of Person Detail Page to correctly show poster labels
Set initial focus to the first filmography poster on Person Detail Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant