Skip to content

fix skip length unit conversion when syncing to/from moonbase - #210

Merged
RadicalMuffinMan merged 2 commits into
Moonfin-Client:masterfrom
jmawet:fix-skip-length-settings
Aug 11, 2026
Merged

fix skip length unit conversion when syncing to/from moonbase#210
RadicalMuffinMan merged 2 commits into
Moonfin-Client:masterfrom
jmawet:fix-skip-length-settings

Conversation

@jmawet

@jmawet jmawet commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Moonbase stores skip length in ms, roku uses s

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • divide skipForward/BackLength by 1000 when pulling from server
  • multiply when pushing

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Before it was pulling from moonbase as "30000", when it should be "30 sec"
  2. Now it correctly converts and shows "30 sec"

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan
RadicalMuffinMan merged commit 153c1f1 into Moonfin-Client:master Aug 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants