Restore CryptoNight-WOW dispatch for algorithm selector 12#58
Closed
MoneroOcean wants to merge 1 commit into
Closed
Restore CryptoNight-WOW dispatch for algorithm selector 12#58MoneroOcean wants to merge 1 commit into
MoneroOcean wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
get_cn_fn()dispatch removed thecase 12mapping so calls using selector12(documented/tested as CryptoNight-WOW) could silently be routed to the wrong hash implementation, breaking share/hash verification for WOW jobs.Description
case 12: return FNA(CN_WOW);toget_cn_fn()inmultihashing.ccso selector12correctly dispatches to the CryptoNight-WOW implementation while preserving the existing height-dependent API behavior.Testing
npm test -- tests/test_sync-wow.jsbut the test run failed in this environment due to a missingbindingsmodule, so automated tests could not complete; the change is a single-line dispatch fix.Codex Task