You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns
Sensitive information exposure: The docker-compose.yaml and environment variable templates contain placeholders for multiple sensitive credentials (DJANGO_SECRET_KEY, AWS_S3_ACCESS_KEY_ID, AWS_S3_SECRET_ACCESS_KEY, OIDC_RP_CLIENT_SECRET, AI_API_KEY, Y_PROVIDER_API_KEY, COLLABORATION_SERVER_SECRET). While these are just templates, there should be clear instructions to ensure these values are properly secured and not committed to version control when populated with actual secrets.
The y-provider service has an incorrect entrypoint configuration. The entrypoint should be a command, but environment variables are being passed instead. This will likely cause the service to fail on startup.
The docker-compose file contains placeholder values for sensitive configuration that should be properly secured before deployment, including API keys, secrets, and credentials.
- DJANGO_ALLOWED_HOSTS=${DOCS_HOST}
- DJANGO_SECRET_KEY=${DJANGO_SECRET_KEY}
- DJANGO_SETTINGS_MODULE=impress.settings
- DJANGO_CONFIGURATION=Production# Logging# Set to DEBUG level for dev only
- LOGGING_LEVEL_HANDLERS_CONSOLE=ERROR
- LOGGING_LEVEL_LOGGERS_ROOT=INFO
- LOGGING_LEVEL_LOGGERS_APP=INFO# Python
- PYTHONPATH=/app# Mail
- DJANGO_EMAIL_HOST=${DJANGO_EMAIL_HOST}
- DJANGO_EMAIL_HOST_USER=${DJANGO_EMAIL_HOST_USER}
- DJANGO_EMAIL_HOST_PASSWORD=${DJANGO_EMAIL_HOST_PASSWORD}
- DJANGO_EMAIL_PORT=${DJANGO_EMAIL_PORT}
- DJANGO_EMAIL_FROM=${DJANGO_EMAIL_FROM}#DJANGO_EMAIL_USE_TLS=true # A flag to enable or disable TLS for email sending.#DJANGO_EMAIL_USE_SSL=true # A flag to enable or disable SSL for email sending.
- DJANGO_EMAIL_BRAND_NAME="Monadical"# DJANGO_EMAIL_LOGO_IMG="https://${DOCS_HOST}/assets/logo-suite-numerique.png"# Media
- AWS_S3_ENDPOINT_URL=https://${S3_HOST}
- AWS_S3_ACCESS_KEY_ID=${AWS_S3_ACCESS_KEY_ID}
- AWS_S3_SECRET_ACCESS_KEY=${AWS_S3_SECRET_ACCESS_KEY}
- AWS_STORAGE_BUCKET_NAME=${BUCKET_NAME}
- MEDIA_BASE_URL=https://${DOCS_HOST}# OIDC
- OIDC_OP_JWKS_ENDPOINT=${OIDC_OP_JWKS_ENDPOINT}
- OIDC_OP_AUTHORIZATION_ENDPOINT=${OIDC_OP_AUTHORIZATION_ENDPOINT}
- OIDC_OP_TOKEN_ENDPOINT=${OIDC_OP_TOKEN_ENDPOINT}
- OIDC_OP_USER_ENDPOINT=${OIDC_OP_USER_ENDPOINT}
- OIDC_OP_LOGOUT_ENDPOINT=${OIDC_OP_LOGOUT_ENDPOINT}
- OIDC_RP_CLIENT_ID=${OIDC_RP_CLIENT_ID}
- OIDC_RP_CLIENT_SECRET=${OIDC_RP_CLIENT_SECRET}
- OIDC_RP_SIGN_ALGO=RS256
- OIDC_RP_SCOPES="openid email"#USER_OIDC_FIELD_TO_SHORTNAME#USER_OIDC_FIELDS_TO_FULLNAME
- LOGIN_REDIRECT_URL=https://${DOCS_HOST}
- LOGIN_REDIRECT_URL_FAILURE=https://${DOCS_HOST}
- LOGOUT_REDIRECT_URL=https://${DOCS_HOST}
- OIDC_REDIRECT_ALLOWED_HOSTS=["https://${DOCS_HOST}"]# AI
- AI_FEATURE_ENABLED=true # is false by default
- AI_BASE_URL=${AI_BASE_URL}
- AI_API_KEY=${AI_API_KEY}
- AI_MODEL=${AI_MODEL} # e.g. llama
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Documentation
Description
Added LaSuite documentation service configuration
Created directory structure for service deployment
Added Docker Compose configuration for docs service
Included environment variable templates
Changes walkthrough 📝
6 files
Add placeholder for helper scriptsAdd placeholder for service state and logsAdd placeholder for docs helper scriptsAdd placeholder for docs service dataAdd placeholder for docs config filesAdd placeholder for config files4 files
Add Docker Compose configuration for docs serviceAdd backend environment variable templatesAdd common environment variables configurationAdd Y-provider environment configuration