feat(cacher): Redis cacher production-ready + 16 integration tests - #42
Merged
Merged
Conversation
…integration tests Fixes P0 gap: RedisCacher.start()/stop() now properly connect/disconnect. Broker calls these during lifecycle — previously they were no-ops, meaning Redis cacher was never actually connected. Changes: - start() → calls connect() (establishes Redis connection) - stop() → calls disconnect() (graceful cleanup) - init() resets connected=False (base sets True, wrong for network cachers) - 16 integration tests with real Redis (get/set/delete/clean/ttl/keys/broker) Evidence: 2371 tests pass, mypy 0, demo 28/28. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redis cacher was 90% implemented but never actually connected —
start()/stop()were no-ops inherited from base class. This PR fixes the lifecycle and adds comprehensive integration tests.Changes
start()connect()— establishes Redis connectionstop()disconnect()— graceful cleanupinit()connected=False(base sets True, wrong for network cachers)Integration Tests
Evidence
🤖 Generated with Claude Code