fix(transit): seq/instanceID heartbeat checks (Node.js parity) - #41
Merged
Merged
Conversation
…ity) Matches Node.js Moleculer base discoverer heartbeatReceived(): - seq mismatch → services changed on remote node → request fresh INFO - instanceID mismatch → node restarted → request fresh INFO - Also includes seq/instanceID in heartbeat payload so remote Python nodes can detect changes without waiting for INFO round-trip Refs: Node.js base.js:205-229 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements seq/instanceID checks in heartbeat handler matching Node.js Moleculer
heartbeatReceived():seqandinstanceIDfieldsWithout this, a remote node that restarts or changes services is never re-discovered via heartbeat — only via the slower INFO round-trip.
Evidence
Test plan
🤖 Generated with Claude Code