Skip to content

fix: stabilize browser e2e after View settings layout drift - #34

Merged
galjos merged 1 commit into
mainfrom
fix/browser-e2e-main
Sep 5, 2026
Merged

fix: stabilize browser e2e after View settings layout drift#34
galjos merged 1 commit into
mainfrom
fix/browser-e2e-main

Conversation

@galjos

@galjos galjos commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Unblock browser CI on main (broken since Keep View settings honest and readable #26) so packet/periodic fix PRs can merge.
  • Camera recipe restore uses toBeCloseTo for position/target/up.
  • Within 5 Å of boundary oxygen expects CH2O · 4 atoms (C is 0.4 Å away via PBC).
  • Pointer pick clicks Fit-layout atom coordinates instead of a stale hard-coded pixel.

Test plan

  • Local: the three previously failing e2e tests pass
  • CI browser job green

Camera recipe compares use approximate equality, within-5Å of O expects
CH2O across the periodic boundary, and pointer pick targets Fit-layout
coordinates.
@galjos
galjos merged commit 026feb0 into main Sep 5, 2026
4 checks passed
@galjos
galjos deleted the fix/browser-e2e-main branch September 5, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant