fix: restart unwrap shifts across vacuum cell boundaries - #33
Merged
Conversation
Forward and reverse unwrap now return zero shifts when either adjacent cell is vacuum, instead of raising and failing the frame request.
galjos
force-pushed
the
fix/vacuum-unwrap-reset
branch
from
September 3, 2026 08:16
57df7c7 to
993e5de
Compare
Camera recipe compares use approximate equality, within-5Å of O expects CH2O across the periodic boundary, and pointer pick targets Fit-layout coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vacuum-to-periodic (and reverse) unwrap steps now reset image shifts to zero instead of raising
ValueError, so unwrapped frame requests can cross an open first frame.Fixes #30.