Refactor input file parser - #582
Conversation
- Introduced InputKey and InputRegistry classes for managing input parameters. - Added Converter specializations for various types including enums. - Implemented tests for input parameter parsing and validation. - Updated CMake configuration to include new test files.
⚡ Performance (instruction count) — ✅ no regressionsper-benchmark breakdown
Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #582 +/- ##
========================================
Coverage 91.44% 91.45%
========================================
Files 322 324 +2
Lines 14628 14771 +143
Branches 4915 4982 +67
========================================
+ Hits 13377 13509 +132
- Misses 1169 1177 +8
- Partials 82 85 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
galjos
left a comment
There was a problem hiding this comment.
Compiled the two headers against the PR head with a small ASan probe; the inline comments quote what it produced.
Main points, in order: dangling reference on duplicate registerKey; no line-shape or keyword normalization in parseLine; bool tokens uppercase-only while every existing parser and input file uses on/off. Nothing wires the registry yet, so nothing breaks today; the first migrated parser would hit all three.
Verified fine: enum conversion via mstd::enum_meta_t<T>::from_string at the pinned mstd commit, line numbers in messages match the existing parsers, test registered in CMake and run in CI.
Review done by Cursor (Claude) on my behalf.
No description provided.