Skip to content

SCRUM-323: fix(rewards) adopt Result pattern in GetRewardProfileQuery and add unit tests - #364

Merged
Moha-sami merged 1 commit into
mainfrom
fix/rewards-get-profile-by-id
Sep 15, 2026
Merged

Moha-sami merged 1 commit into
mainfrom
fix/rewards-get-profile-by-id

Conversation

@Moha-sami

Copy link
Copy Markdown
Owner

Summary

Hardening and refactoring for merged PR #363 (SCRUM-323):

  • GetRewardProfileQuery: adopt Result pattern, return Result.NotFound on missing item, switch queries to untracked AsNoTracking() / Query(true).
  • Fix naming typos: _redemptionRepository, redemptionCount.
  • RewardsController.GetRewardById: map Result error states to HTTP 404 NotFound and 200 OK.
  • Added comprehensive unit tests in GetRewardProfileQueryTests (not-found, KPI stats computation, zero stats, and controller status codes).

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hr-system Ready Ready Preview Sep 15, 2026 9:04pm UTC

@github-actions

Copy link
Copy Markdown

Automated PR Validation Feedback

All Checks Passed!

  • Jira key / Task reference detected.
  • Code formatting passed (3 changed C# file(s)).
  • .NET 10 solution compiled successfully.
  • .NET analyzers passed.
  • Security scan skipped (no dependency changes in this PR).

Ready for maintainer review!

@Moha-sami
Moha-sami merged commit b48c6f0 into main Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant