[215_7] fix ellipse array bounds issue (#2944)#2948
Closed
physical168 wants to merge 3 commits intoMoganLab:mainfrom
Closed
[215_7] fix ellipse array bounds issue (#2944)#2948physical168 wants to merge 3 commits intoMoganLab:mainfrom
physical168 wants to merge 3 commits intoMoganLab:mainfrom
Conversation
Author
|
This PR addresses the crash issue when interacting with ellipses in drawing mode (#2944). Problem: Solution: Details:
|
Contributor
|
Please format your code with Clang@19. |
Author
|
Thanks for reviewing my code! I've just reformatted the code using Clang and pushed the update. Please check if it complies with the project's style. |
Contributor
|
I was unable to reproduce the crash by following the provided test steps. |
GatsbyUSTC
reviewed
Mar 17, 2026
| Fixed a program crash issue when selecting or box-selecting an ellipse. | ||
|
|
||
| ### Why | ||
| In the original `ellipse_rep::get_control_points`, the function informed the caller that it had 3 control points (`np=3`, two foci and one boundary point). However, the `abs` array, which represents the parameter range for each point on the curve, was hardcoded to initialize with only two elements (`array<double> (0.0, 1.0)`). This caused an out-of-bounds access on `abs[2]` during the edge-snapping retrieval or distance calculation in the `curve_box_rep::graphical_select` function (which iterates from 0 to `np` seeking `abs[i]` and `abs[(i+1)%np]`), leading to undefined behavior and infinite loops. |
Collaborator
There was a problem hiding this comment.
感觉这种修复方式比较临时，是否有方案对于abs访问加限制，对于不合理的访问进行兜底，而不是未定义行为导致crash
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.