Conversation
Five findings from the 2026-09-13 shipyard-cmake cutover, deliberately left unfixed: two check-comments.sh blind spots (heredocs, trailing comments), the family-wide developer-path documentation gap, 1password's pre-existing broken cmake-10_9-gate job, and two new gate blind spots the cutover itself found -- check 18 (shell-recipe detection) and check 16 (cmake locator detection) each missed a minority-vs-majority share of real call sites across the fourteen repos. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTxFde2TJMmp5p64DhvDSK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records five findings from the 2026-09-13 shipyard-cmake cutover that were surfaced but deliberately not fixed as part of that flag day:
check-comments.shcannot see inside heredocs — ~40 lines of prose inpackage-pkg.sh's rendered pre/postinstall never swept.cmake-10_9-gatejob is broken independently of this flag day (pre-existing, spec D8 left it alone).*.bats,tests/*.sh, extensionless executables,*.cmake/CMakeLists.txt, and bare(— and real breakage hid in every one of them (porthole's bats test andgenerate-viewerrecipe, fiveecho "(build it: ...)"recipes across four repos). Across fourteen repos the gate saw a minority of real call sites (e.g. magic-trackpad2: 4 visible vs 18 invisible)..cmake/package[s](missing$HOME/.local/share/cmake/...locators in clang, golang, swift-runtime) and skipstests/entirely (magic-trackpad2'stests/test_appcast_notes.shmatched the pattern exactly and was still never reported).The last two (checks 18 and 16) were not anticipated by the original task brief — the cutover itself found them while auditing the other three.
This is documentation only: five new numbered entries appended to
BACKLOG.md, matching its existing entry style (evidence-first, citing concrete repos/files/lines).Test plan
sh scripts/check-comments.shexits 0sh scripts/check-family-conventions.shexits 0BACKLOG.mdwas 155 lines before, 204 after (49 new lines, no existing content altered)🤖 Generated with Claude Code
https://claude.ai/code/session_01GTxFde2TJMmp5p64DhvDSK