chore(deps): update dependency openssh/openssh-portable to v10 - autoclosed - #4
Closed
renovate[bot] wants to merge 1 commit into
Closed
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
schmonz
added a commit
that referenced
this pull request
Sep 13, 2026
…10.x Renovate #4 has been blocked since it opened: ssh-add-keychain.patch failed 3 of 11 hunks on 10.5p1 and apply-patches.sh stops at the first failure. Behind it, two more patches also no longer applied. sshd-session-inetd-fix.patch is DELETED, not ported: upstream adopted it. 10.5p1 already reads `if (!debug_flag && !inetd_flag)` verbatim, and REEXEC_STARTUP_PIPE_FD no longer exists (now REEXEC_CONFIG_PASS_FD), so the hunk-1 concern is gone too. ssh-add-keychain.patch: hunk 3 dropped (upstream now initialises `*private = NULL, *cert = NULL` itself). The remaining hunks carry 10.5p1's own option string -- upstream added N and Q since 9.9p2 and restating the old string would silently delete both. The --apple-load-keychain block MOVED: it calls add_file(agent_fd, ...), and upstream relocated ssh_get_authentication_socket() to after the action-validation check, so the textually-equivalent position would hand add_file() an unconnected agent_fd. Its call also gained an argument -- 10.5p1's add_file() takes Nflag between qflag and skprovider. ssh-agent-launchd.patch: re-derived from Apple's own tree (apple-oss-distributions/OpenSSH @ OpenSSH-354.120.2, based on 10.2p1), whose ssh-agent.c differs from upstream by exactly these seven __APPLE_LAUNCHD__ hunks -- Wowfunhappy's is the same patch rebased to 9.9p2. Apple's PLACEMENT is adopted (the check-in sits after closefrom(), which is new in 10.x and would otherwise purge the listener fds; the fds arrive via the launch_msg IPC after the purge). Apple's API is NOT: they now call launch_activate_socket(), which arrived in 10.10, is undeclared in the 10.9 SDK's launch.h and absent from its libSystem. It compiles with only an implicit-declaration warning and would fail on the platform this product exists for. We keep launch_msg(). Verified natively on Mac OS X 10.9.5 x86_64 (not cross-built): configure and make clean with -Werror=implicit-function-declaration, compat guard reports 4 binaries clean, `ssh -V` says OpenSSH_10.5p1/LibreSSL 3.9.2, `ssh-agent -l` reaches launchd (refused, as expected off-launchd), and an agent/ssh-add round-trip adds and lists a key. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Zns48xhomhdoijbAuLEXv
renovate
Bot
changed the title
auto-merge was automatically disabled
September 13, 2026 15:19
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
V_9_9_P2→V_10_5_P1Release Notes
openssh/openssh-portable (openssh/openssh-portable)
vV_10_5_P1Compare Source
vV_10_4_P1Compare Source
vV_10_3_P1Compare Source
vV_10_2_P1Compare Source
vV_10_1_P1Compare Source
vV_10_0_P2Compare Source
vV_10_0_P1Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.